Skip to content

Fix: Clicking on the empty dialog box on the agent exploration page will result in an error.#14198

Merged
yingfeng merged 3 commits intoinfiniflow:mainfrom
cike8899:fix-agent-explore
Apr 17, 2026
Merged

Fix: Clicking on the empty dialog box on the agent exploration page will result in an error.#14198
yingfeng merged 3 commits intoinfiniflow:mainfrom
cike8899:fix-agent-explore

Conversation

@cike8899
Copy link
Copy Markdown
Contributor

@cike8899 cike8899 commented Apr 17, 2026

What problem does this PR solve?

Fix: Clicking on the empty dialog box on the agent exploration page will result in an error.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 17, 2026
@cike8899 cike8899 added the ci Continue Integration label Apr 17, 2026
@cike8899 cike8899 marked this pull request as draft April 17, 2026 11:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f96c023b-c101-4fd3-a628-abb80ca0687d

📥 Commits

Reviewing files that changed from the base of the PR and between b34a726 and a691327.

📒 Files selected for processing (2)
  • web/src/pages/agent/explore/components/session-list.tsx
  • web/src/pages/agent/explore/hooks/use-select-derived-session-list.ts
📝 Walkthrough

Walkthrough

SessionList now provides a default empty string value for selectedSessionId instead of requiring it to be passed. The useSelectDerivedSessionList hook removes ID generation for temporary sessions, initializing their id as an empty string instead.

Changes

Cohort / File(s) Summary
Session Management Initialization
web/src/pages/agent/explore/components/session-list.tsx, web/src/pages/agent/explore/hooks/use-select-derived-session-list.ts		 SessionList adds default empty string parameter for selectedSessionId; hook removes generateConversationId usage and initializes temporary session id as empty string instead of unique value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop and a skip through session state,
Empty strings now seal the fate,
No more IDs generated with care,
Just empty defaults everywhere! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the bug being fixed: clicking the empty dialog on the agent exploration page causes an error.
Description check ✅ Passed The description follows the required template with the problem statement and bug fix type clearly identified, though additional implementation details could enhance clarity.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the 🐞 bug Something isn't working, pull request that fix bug. label Apr 17, 2026
@yingfeng yingfeng marked this pull request as ready for review April 17, 2026 12:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.66%. Comparing base (c3387cd) to head (ae949f1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14198   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files          10       10           
  Lines         690      690           
  Branches      108      108           
=======================================
  Hits          667      667           
  Misses          8        8           
  Partials       15       15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yingfeng yingfeng merged commit 6712b50 into infiniflow:main Apr 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🐞 bug Something isn't working, pull request that fix bug. ci Continue Integration size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cike8899 @yingfeng